medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

Fix etcd guard check for control plane remediation #276

Closed slintes closed 9 months ago

slintes commented 9 months ago

When the PDB doesn't allow disruptions, we need to check if the unhealthy node is already disrupted. If so, remediation is allowed.

Fix for #272 ECOPROJECT-1003 ECOPROJECT-1806

Note for reviewers: probably makes sense to review the commits separately, because one is reorganizing e2e test, while the next one adds the new test

openshift-ci[bot] commented 9 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 9 months ago

/test 4.14-openshift-e2e

clobrano commented 9 months ago

/lgtm Giving a chance to get more reviews, feel free to unhold /hold

slintes commented 9 months ago

/test 4.14-openshift-e2e

slintes commented 9 months ago

/test 4.14-openshift-e2e

clobrano commented 9 months ago

/lgtm Giving a chance to get more reviews, feel free to unhold /hold

slintes commented 9 months ago

/test 4.14-openshift-e2e

slintes commented 9 months ago

/test 4.14-openshift-e2e

slintes commented 9 months ago

/test 4.14-openshift-e2e

slintes commented 9 months ago

/test 4.14-openshift-e2e

slintes commented 9 months ago

/test 4.14-openshift-e2e

slintes commented 9 months ago

/test 4.14-openshift-e2e

slintes commented 9 months ago

wait until 277 is merged before marking as Ready For Review and running more e2e tests, in order to save CI resources

slintes commented 9 months ago

/hold cancel

slintes commented 9 months ago

/retest

razo7 commented 9 months ago

/lgtm nice fix