Fix MHC node lease deletion

[slintes]

Delete the node lease when MHC remediation is done

ECOPROJECT-1831

[openshift-ci[bot]]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[slintes]

/test 4.14-openshift-e2e

[slintes]

/test 4.14-openshift-e2e

[slintes]

/test 4.14-openshift-e2e

[slintes]

but I am not sure I undertand how the change in MHC reconcile are resolving the MHC node lease deletion issue

look at the HandleHealthyNode function, whose return values are better evaluated now. It will delete CRs, but only if no CRs are left it will also delete the lease in CleanUp. So we need to reconcile again until all CRs are gone.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[clobrano]

/hold

to let the other threads be closed, feel free to unhold

[razo7]

So we need to reconcile again until all CRs are gone.

Gotcha, so as long HandleHealthyNode function returns that there are remaining remediation CRs we will requeue reconciliation. On the last time, it would be zero and the lease would be invalidated (from cleanup).

[slintes]

/hold cancel

[slintes]

/test all

[razo7]

/lgtm

[slintes]

/test all

[clobrano]

/lgtm