medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

Update and re-enable k8s e2e test #292

Closed slintes closed 8 months ago

slintes commented 8 months ago

k8s e2e test didn't work anymore since SNR switched from systemctl reboot to sysrq based reboots. For some reason reboot also doesn't work anymore, the kind node container doesn't restart, sometimes at least. As a workaround switch to a custom build of SNR, which just starts kubelet as "reboot" command (kubelet is stopped in e2e tests for making node unready)

Some other things modified along the way:

openshift-ci[bot] commented 8 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

slintes commented 8 months ago

/test 4.14-openshift-e2e

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 8 months ago

Giving a chance to get more reviews, feel free to unhold /hold

slintes commented 8 months ago

/hold cancel