Closed clobrano closed 4 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clobrano
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I'm fine with removing it from container-push
, but why removing it completely?
(the answer to this probably should be in the description...)
I'm fine with removing it from
container-push
, but why removing it completely? (the answer to this probably should be in the description...)
yeah, sorry. Updated description (it's a clean up basically)
Clean up Makefile from unused targets that build the catalog in a deprecated way
Unused by CI, and being deprecated, should not automatically mean that we should remove them IMHO, as long as they still work on "some" clusters. Can very well be that others create and use catalogs. I'd prefer to keep the targets, and update them to create a file based catalog (later on).
this is OpenshiftCI specific, doesn't matter that much IMHO 🤷🏼♂️
this is OpenshiftCI specific, doesn't matter that much IMHO 🤷🏼♂️
it is operator-framework related though
$ opm index add --container-tool docker --mode semver --tag quay.io/clobrano/machine-deletion-remediation-operator-catalog:latest --bundles quay.io/clobrano/machine-deletion-remediation-operator-bundle:latest
WARN[0000] DEPRECATION NOTICE:
Sqlite-based catalogs and their related subcommands are deprecated. Support for
them will be removed in a future release. Please migrate your catalog workflows
to the new file-based catalog format.
Change plan. I'll update the target to create file-based catalogs instead
Clean up Makefile from unused targets that build the catalog in a deprecated way
see https://docs.ci.openshift.org/docs/how-tos/testing-operator-sdk-operators/#moving-to-file-based-catalog
TODO