medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
88 stars 18 forks source link

[WIP] Remove catalog build from Makefile #296

Closed clobrano closed 4 months ago

clobrano commented 6 months ago

Clean up Makefile from unused targets that build the catalog in a deprecated way

see https://docs.ci.openshift.org/docs/how-tos/testing-operator-sdk-operators/#moving-to-file-based-catalog

TODO

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 6 months ago

I'm fine with removing it from container-push, but why removing it completely? (the answer to this probably should be in the description...)

clobrano commented 6 months ago

I'm fine with removing it from container-push, but why removing it completely? (the answer to this probably should be in the description...)

yeah, sorry. Updated description (it's a clean up basically)

slintes commented 6 months ago

Clean up Makefile from unused targets that build the catalog in a deprecated way

Unused by CI, and being deprecated, should not automatically mean that we should remove them IMHO, as long as they still work on "some" clusters. Can very well be that others create and use catalogs. I'd prefer to keep the targets, and update them to create a file based catalog (later on).

see https://docs.ci.openshift.org/docs/how-tos/testing-operator-sdk-operators/#moving-to-file-based-catalog

this is OpenshiftCI specific, doesn't matter that much IMHO 🤷🏼‍♂️

clobrano commented 6 months ago

this is OpenshiftCI specific, doesn't matter that much IMHO 🤷🏼‍♂️

it is operator-framework related though

$ opm index add --container-tool docker --mode semver --tag quay.io/clobrano/machine-deletion-remediation-operator-catalog:latest --bundles quay.io/clobrano/machine-deletion-remediation-operator-bundle:latest 
WARN[0000] DEPRECATION NOTICE:
Sqlite-based catalogs and their related subcommands are deprecated. Support for
them will be removed in a future release. Please migrate your catalog workflows
to the new file-based catalog format.
clobrano commented 4 months ago

Change plan. I'll update the target to create file-based catalogs instead