search

medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

Fix install of latest Go z version #297

Closed slintes closed 7 months ago

slintes commented 7 months ago

Why we need this PR

Image build fails with go: updating go.mod requires go >= 1.21.8 (running go 1.21.7; GOTOOLCHAIN=local)

Changes made

Set GOTOOLCHAIN=auto as env var in the Dockerfile

Which issue(s) this PR fixes

None

Test plan

Not needed, successful build and e2e tests is prove enough :)

openshift-ci[bot] commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 7 months ago

/test 4.14-openshift-e2e /test 4.14-test

slintes commented 7 months ago

/cherrypick release-0.7

openshift-cherrypick-robot commented 7 months ago

@slintes: once the present PR merges, I will cherry-pick it on top of release-0.7 in a new PR and assign it to you.

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/297#issuecomment-1981023634): >/cherrypick release-0.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mshitrit commented 7 months ago

/lgtm

slintes commented 7 months ago

/retest

slintes commented 7 months ago

/retest

slintes commented 7 months ago

/override ci/prow/4.14-openshift-e2

openshift-ci[bot] commented 7 months ago

@slintes: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/297#issuecomment-1981593513): >/override ci/prow/4.14-openshift-e2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
slintes commented 7 months ago

/override pull-ci-medik8s-node-healthcheck-operator-main-4.14-openshift-e2e

openshift-ci[bot] commented 7 months ago

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.14-openshift-e2e

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/297#issuecomment-1981594561): >/override pull-ci-medik8s-node-healthcheck-operator-main-4.14-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 7 months ago

@slintes: new pull request created: #298

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/297#issuecomment-1981023634): >/cherrypick release-0.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.