search

medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
88 stars 18 forks source link

Don't use `replaces` field for k8s release #299

Closed slintes closed 6 months ago

slintes commented 6 months ago

Why we need this PR

Community hubs reject replaces field when using semver as update strategy

Changes made

Removed replaces field from generic make target to ocp only

Test plan

see success after removing field in https://github.com/k8s-operatorhub/community-operators/pull/3982

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 6 months ago

/lgtm