medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
88 stars 18 forks source link

Add Prometheus configuration to bundle OCP #305

Closed clobrano closed 5 months ago

clobrano commented 5 months ago

Why we need this PR

To allow User Workload Prometheus (UWP) metrics scraping for NHC, we need to modify existing bundle configuration as well as and deploy new configuration.

Changes made

Currently, only in OCP we are sure to have Prometheus installed, so this PR affects the bundle created for OCP only.

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1760

Test plan

To configure NHC with UWP follow the steps in config/optional/prometheus-ocp/readme.md. To ease the test process, the script hack/ocp/test_create_bundle_ocp_image_in_quay.sh build the bundle image and pushes it to quay.io.

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

clobrano commented 5 months ago

/test 4.15-openshift-e2e

razo7 commented 5 months ago

The test didn't start. Lets try again /test 4.15-openshift-e2e

razo7 commented 5 months ago

/lgtm Giving a chance to get more reviews /hold

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 5 months ago

/retest

clobrano commented 5 months ago

/unhold