search

medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

Ensure MachineAPI is enabled before trying to use its resources #306

Closed clobrano closed 6 months ago

clobrano commented 7 months ago

Why we need this PR

Currently, NHC only checks if it runs on OCP before trying to access MachineAPI resources, however not all OCP clusters have MachineAPI enabled and the controller fails to start in such conditions.

Changes made

Verify if MachineAPI is in the list of the Cluster's EnabledCapabilities

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1902

Todo

openshift-ci[bot] commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

clobrano commented 6 months ago

/test 4.15-openshift-e2e

clobrano commented 6 months ago

/test 4.15-openshift-e2e

clobrano commented 6 months ago

/test 4.15-openshift-e2e

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 6 months ago

/retest

openshift-ci[bot] commented 6 months ago

@clobrano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.13-openshift-e2e a3be2568d1dd632877d506d083cd289e72fe56ad link unknown /test 4.13-openshift-e2e
ci/prow/4.12-openshift-e2e a3be2568d1dd632877d506d083cd289e72fe56ad link unknown /test 4.12-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
clobrano commented 6 months ago

I've been allucinated here. I merged the branch without noticing the failed tests :facepalm:

mshitrit commented 6 months ago

I've been allucinated here. I merged the branch without noticing the failed tests 🤦

Since 4.14 + passed, you are most likely in the clear. To make sure let's keep an eye on unrelated #303 and see that all the tests are clear.