skip remediation for excluded nodes

mshitrit commented 6 months ago

Why we need this PR

In case a Node is excluded from remediation, NHC should not try to remediate it

Changes made

NHC will not create a remediation for a node with the relevant label

Which issue(s) this PR fixes

ECOPROJECT-1844

Test plan

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

mshitrit commented 6 months ago

/test ?

openshift-ci[bot] commented 6 months ago

@mshitrit: The following commands are available to trigger required jobs:

/test 4.12-ci-bundle-my-bundle
/test 4.12-images
/test 4.12-openshift-e2e
/test 4.12-test
/test 4.13-ci-bundle-my-bundle
/test 4.13-images
/test 4.13-openshift-e2e
/test 4.13-test
/test 4.14-ci-bundle-my-bundle
/test 4.14-images
/test 4.14-openshift-e2e
/test 4.14-test
/test 4.15-ci-bundle-my-bundle
/test 4.15-images
/test 4.15-openshift-e2e
/test 4.15-test

Use /test all to run all jobs.

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/307#issuecomment-2025141291): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

mshitrit commented 6 months ago

/test 4.15-openshift-e2e

mshitrit commented 6 months ago

/test 4.15-openshift-e2e

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,mshitrit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

clobrano commented 6 months ago

Noted now that the title has a typo. It's a nitpick but it might be helpful to fix it if we need to search for it in the future :wink:

mshitrit commented 6 months ago

/test 4.15-openshift-e2e

mshitrit commented 6 months ago

/unhold

medik8s / node-healthcheck-operator