medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

Revert "Ensure MachineAPI is enabled before trying to use its resources" #309

Closed clobrano closed 6 months ago

clobrano commented 6 months ago

Reverts medik8s/node-healthcheck-operator#306

306 relies on MachineAPI to appear in the list of the cluster enabled capabilities

oc get clusterversions.config.openshift.io version -o json | jq '.status.capabilities.enabledCapabilities'

however this is available only in OCP 4.14+

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 6 months ago

/test ci/prow/4.12-ci-bundle-my-bundle

openshift-ci[bot] commented 6 months ago

@slintes: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/309#issuecomment-2036985340): >/test ci/prow/4.12-ci-bundle-my-bundle Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
slintes commented 6 months ago

/test 4.12-ci-bundle-my-bundle

clobrano commented 6 months ago

/retest

slintes commented 6 months ago

let's save some time, we need all tests after another PR was merged

/test all

clobrano commented 6 months ago

/skip

clobrano commented 6 months ago

The test has passed, but CI seems confused about it. Try overriding it

/override "ci/prow/4.12-openshift-e2e"

openshift-ci[bot] commented 6 months ago

@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.12-openshift-e2e

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/309#issuecomment-2039137653): >/override "ci/prow/4.12-openshift-e2e" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.