search

medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
88 stars 18 forks source link

Prevent overriding of pullspec set by CI #310

Closed clobrano closed 5 months ago

clobrano commented 5 months ago

Why we need this PR

CI is expected to set a specific pullspec for the NHC image it is building and testing. This pullspec however was overridden by our multistep image build in bundle.ci.Dockerfile (which in turn is necessary to test the console-plugin, which is only contained in the OCP bundle).

Changes made

This change prevents such overriding by:

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

New changes are detected. LGTM label has been removed.

clobrano commented 5 months ago

/override 4.13-openshift-e2e

openshift-ci[bot] commented 5 months ago

@clobrano: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/310#issuecomment-2037665399): >/override 4.13-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
clobrano commented 5 months ago

/override "ci/prow/4.12-openshift-e2e"

openshift-ci[bot] commented 5 months ago

@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.12-openshift-e2e

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/310#issuecomment-2037667050): >/override "ci/prow/4.12-openshift-e2e" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
clobrano commented 5 months ago

/override "ci/prow/4.13-openshift-e2e"

openshift-ci[bot] commented 5 months ago

@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.13-openshift-e2e

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/310#issuecomment-2037667635): >/override "ci/prow/4.13-openshift-e2e" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.