medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
88 stars 18 forks source link

Build a file-based catalog #311

Open clobrano opened 5 months ago

clobrano commented 5 months ago

Why we need this PR

Currently NHC's Makefile creates a db-based catalog, which is deprecated

DEPRECATION NOTICE:
Sqlite-based catalogs and their related subcommands are deprecated. Support for
them will be removed in a future release. Please migrate your catalog workflows
to the new file-based catalog format.

Changes made

This change creates a file-based catalog

https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-managing-custom-catalogs-fb

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1948

Test plan

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 5 months ago

interesting, it seems kind isn't happy with this change

2024/04/05 17:09:58 render reference "kind-registry:5000/node-healthcheck-operator-bundle:latest": error resolving name for image ref kind-registry:5000/node-healthcheck-operator-bundle:latest: failed to do request: Head "https://kind-registry:5000/v2/node-healthcheck-operator-bundle/manifests/latest": http: server gave HTTP response to HTTPS client
clobrano commented 4 months ago

I am testing the k8s-e2e phase, do not merge /hold