medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
88 stars 18 forks source link

(v2) Ensure MachineAPI is enabled before trying to use its resources #315

Closed clobrano closed 4 months ago

clobrano commented 5 months ago

Why we need this PR

Currently, NHC only checks if it runs on OCP before trying to access MachineAPI resources, however not all OCP clusters have MachineAPI enabled.

Changes made

HasMachineAPI detection

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1902

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 5 months ago

/test 4.12-openshift-e2e

clobrano commented 5 months ago

/test 4.13-openshift-e2e

clobrano commented 5 months ago

need to double check something, no need to review it yet

clobrano commented 5 months ago

Ok, it should be good now :)

slintes commented 4 months ago

🤞🏼

/test 4.13-openshift-e2e

clobrano commented 4 months ago

/test 4.13-openshift-e2e

clobrano commented 4 months ago

/test 4.15-openshift-e2e

mshitrit commented 4 months ago

/lgtm

clobrano commented 4 months ago

/retest

clobrano commented 4 months ago

merging manually as tide has some problems at the moment