Closed clobrano closed 4 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clobrano
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test 4.12-openshift-e2e
/test 4.13-openshift-e2e
need to double check something, no need to review it yet
Ok, it should be good now :)
🤞🏼
/test 4.13-openshift-e2e
/test 4.13-openshift-e2e
/test 4.15-openshift-e2e
/lgtm
/retest
merging manually as tide
has some problems at the moment
Why we need this PR
Currently, NHC only checks if it runs on OCP before trying to access MachineAPI resources, however not all OCP clusters have MachineAPI enabled.
Changes made
HasMachineAPI detection
Which issue(s) this PR fixes
https://issues.redhat.com/browse/ECOPROJECT-1902