medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
88 stars 18 forks source link

Fix Makefile all target #319

Closed clobrano closed 5 months ago

clobrano commented 5 months ago

Why we need this PR

Makefile's "all" target still has the old "container-build" dependency, which was replaced by "container-build-ocp".

Changes made

Replace "container-build" dependency with "container-build-ocp" in Makefile target.

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mshitrit commented 5 months ago

@clobrano I think you can close this PR in favor of #317

clobrano commented 5 months ago

@clobrano I think you can close this PR in favor of https://github.com/medik8s/node-healthcheck-operator/pull/317

I didn't notice it was already done, thanks!

/close

openshift-ci[bot] commented 5 months ago

@clobrano: Closed this PR.

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/319#issuecomment-2046650088): >> @clobrano I think you can close this PR in favor of https://github.com/medik8s/node-healthcheck-operator/pull/317 > >I didn't notice it was already done, thanks! > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.