search

medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

prevent multiple "node unhealthy" events #321

Closed mshitrit closed 6 months ago

mshitrit commented 6 months ago

Why we need this PR

DetectedUnhealthy is generated multiple times for the same node, which might be confusing for the user.

Changes made

In case a remediation is already created for a node, skip DetectedUnhealthy event

Which issue(s) this PR fixes

ECOPROJECT-1890

Test plan

openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

mshitrit commented 6 months ago

waiting for #313 merge before adding unit tests

mshitrit commented 6 months ago

/test 4.15-openshift-e2e

mshitrit commented 6 months ago

/test 4.15-openshift-e2e

mshitrit commented 6 months ago

/test 4.15-openshift-e2e

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,mshitrit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment