Reconcile if ExcludeFromRemediation label is removed

medik8s / node-healthcheck-operator

K8s Node Health Check Operator

Apache License 2.0

88 stars 18 forks source link

Reconcile if ExcludeFromRemediation label is removed #329

Closed clobrano closed 3 months ago

clobrano commented 3 months ago

Why we need this PR

In case ExcludeFromRemediation label is present, remediation is skipped, however if the Node is still unhealthy when the label is removed it should be reconciled.

Changes made

Watch for changes in the Node's labels. If ExcludeFromRemediation is removed reconcile the Node.

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1988

Test plan

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment