medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
88 stars 18 forks source link

minor fixes #330

Closed slintes closed 2 months ago

slintes commented 3 months ago

Why we need this PR

testing tide with little fixes

Changes made

clobrano commented 3 months ago

/lgtm

slintes commented 3 months ago

/retest

slintes commented 2 months ago

/approve

slintes commented 2 months ago

/retest

slintes commented 2 months ago

/approve cancel

slintes commented 2 months ago

/approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 2 months ago

/test 4.12-test

slintes commented 2 months ago

/retest

slintes commented 2 months ago

/retest

slintes commented 2 months ago

/retest

slintes commented 2 months ago

/test 4.15-openshift-e2e

openshift-ci[bot] commented 2 months ago

@slintes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.16-openshift-e2e 036a3d9bffc6265487f0b0ce5ad32cb459ddf3d3 link false /test 4.16-openshift-e2e
ci/prow/4.15-openshift-e2e 036a3d9bffc6265487f0b0ce5ad32cb459ddf3d3 link false /test 4.15-openshift-e2e
ci/prow/4.17-openshift-e2e 036a3d9bffc6265487f0b0ce5ad32cb459ddf3d3 link false /test 4.17-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
slintes commented 1 month ago

/cherry-pick release-0.8

openshift-cherrypick-robot commented 1 month ago

@slintes: new pull request created: #340

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/330#issuecomment-2272870165): >/cherry-pick release-0.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.