medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

CI Release step "Create release with manifests" needs tag #332

Closed clobrano closed 4 months ago

clobrano commented 4 months ago

Why we need this PR

Since this job is not triggered by a tag anymore, the tag itself needs to be provided via configuration.

Changes made

Provide the tag value from job's input

Also, uncommented logging of PREVIOUS_VERSION input which is needed for some jobs

Which issue(s) this PR fixes

Test plan

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

clobrano commented 4 months ago

/test 4.15-openshift-e2e

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 2 months ago

/cherry-pick release-0.8

openshift-cherrypick-robot commented 2 months ago

@slintes: new pull request created: #339

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/332#issuecomment-2272867345): >/cherry-pick release-0.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.