Fix e2e

[slintes]

Why we need this PR

Broken e2e test because of SNR support multiple templates feature

Changes made

Look for CR with node name in annotation instead of CR name

Also:

• always set node name annotation, I don't see a reason to not do that
• make CR name nicer in case it doesn't match node name by adding a "-" between node name and suffix

[slintes]

/test 4.12-openshift-e2e /test 4.16-openshift-e2e

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[slintes]

test fails on OCP 4.17 because it doesn't find the ConsolePlugin. I see this in the NHC logs:

E0701 14:29:51.097198       1 reflector.go:147] sigs.k8s.io/controller-runtime/pkg/cache/internal/informers.go:105: Failed to watch *v1alpha1.ConsolePlugin: failed to list *v1alpha1.ConsolePlugin: conversion webhook for console.openshift.io/v1, Kind=ConsolePlugin failed: Post "https://webhook.openshift-console-operator.svc:9443/crdconvert?timeout=30s": service "webhook" not found

However, I don't see an error the plugin wasn't created. Might be a temporary issue in current OCP 4.17 state.

Logs: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/medik8s_node-healthcheck-operator/334/pull-ci-medik8s-node-healthcheck-operator-main-4.17-openshift-e2e/1807769565258584064

/override ci/prow/4.17-openshift-e2e

[openshift-ci[bot]]

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.17-openshift-e2e

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/334#issuecomment-2200436326): >test fails on OCP 4.17 because it doesn't find the ConsolePlugin. I see this in the NHC logs: >``` >E0701 14:29:51.097198 1 reflector.go:147] sigs.k8s.io/controller-runtime/pkg/cache/internal/informers.go:105: Failed to watch *v1alpha1.ConsolePlugin: failed to list *v1alpha1.ConsolePlugin: conversion webhook for console.openshift.io/v1, Kind=ConsolePlugin failed: Post "https://webhook.openshift-console-operator.svc:9443/crdconvert?timeout=30s": service "webhook" not found >``` >However, I don't see an error the plugin wasn't created. >Might be a temporary issue in current OCP 4.17 state. > >Logs: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/medik8s_node-healthcheck-operator/334/pull-ci-medik8s-node-healthcheck-operator-main-4.17-openshift-e2e/1807769565258584064 > >/override ci/prow/4.17-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[slintes]

/override ci/prow/4.17-openshift-e2e /test 4.16-openshift-e2e

[openshift-ci[bot]]

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.17-openshift-e2e

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/334#issuecomment-2200602199): >/override ci/prow/4.17-openshift-e2e >/test 4.16-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[slintes]

/cherry-pick release-0.8

[openshift-cherrypick-robot]

@slintes: new pull request created: #342

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/334#issuecomment-2272874399): >/cherry-pick release-0.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.