search

medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

Remove snr's dependency #335

Closed mshitrit closed 2 months ago

mshitrit commented 3 months ago

Why we need this PR

Note: I haven't updated NodeHealthCheck sample file, since I think it's still nice to have some valid template populated when NHC is created manually

Which issue(s) this PR fixes

ECOPROJECT-1216

Test plan

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

mshitrit commented 3 months ago

/test 4.16-openshift-e2e

mshitrit commented 3 months ago

/test 4.16-openshift-e2e

mshitrit commented 3 months ago

/test 4.16-openshift-e2e

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [clobrano,mshitrit,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 2 months ago

/retest

mshitrit commented 2 months ago

/retest

slintes commented 2 months ago

this is known...

/override ci/prow/4.17-openshift-e2e

openshift-ci[bot] commented 2 months ago

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.17-openshift-e2e

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/335#issuecomment-2244467494): >this is known... > >/override ci/prow/4.17-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mshitrit commented 2 months ago

/unhold