medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
88 stars 18 forks source link

Disable SNR dependency #337

Closed timbuchwaldt closed 1 month ago

timbuchwaldt commented 1 month ago

Fixes #333 Probably needs a warning upon release about removal.

Why we need this PR

Remove default dependency on SNR which isn't wanted by everyone.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timbuchwaldt Once this PR has been reviewed and has the lgtm label, please assign slintes for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

Hi @timbuchwaldt. Thanks for your PR.

I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
clobrano commented 1 month ago

Hey @timbuchwaldt, thank you so much for your contribution to the project! This change is already being handled by #335 :wink:

slintes commented 1 month ago

/close

openshift-ci[bot] commented 1 month ago

@slintes: Closed this PR.

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/337#issuecomment-2231451311): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.