Closed timbuchwaldt closed 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: timbuchwaldt Once this PR has been reviewed and has the lgtm label, please assign slintes for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @timbuchwaldt. Thanks for your PR.
I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Hey @timbuchwaldt, thank you so much for your contribution to the project! This change is already being handled by #335 :wink:
/close
@slintes: Closed this PR.
Fixes #333 Probably needs a warning upon release about removal.
Why we need this PR
Remove default dependency on SNR which isn't wanted by everyone.