search

medik8s / node-healthcheck-operator

K8s Node Health Check Operator
Apache License 2.0
91 stars 18 forks source link

Use console/v1 #345

Closed slintes closed 2 months ago

slintes commented 2 months ago

Why we need this PR

ConsolePlugin doesn't work anymore on OCP 4.17

Changes made

Use console v1 instead of v1alpha1

Fixes ECOPROJECT-2078

openshift-ci[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 2 months ago

/test 4.12-openshift-e2e /test 4.17-openshift-e2e

slintes commented 2 months ago

/test 4.12-test /test 4.17-test

slintes commented 2 months ago

manually confirmed that console plugin is working on 4.17

slintes commented 2 months ago

/cherry-pick release-0.8

openshift-cherrypick-robot commented 2 months ago

@slintes: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you.

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/345#issuecomment-2274035235): >/cherry-pick release-0.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
slintes commented 2 months ago

4.12 failed with conversion webhook for [console.openshift.io/v1alpha1](http://console.openshift.io/v1alpha1), Kind=ConsolePlugin failed: Post "https://webhook.openshift-console-operator.svc:9443/crdconvert?timeout=30s": x509: certificate signed by unknown authority :/

let's test all versions...

/test 4.13-openshift-e2e /test 4.14-openshift-e2e /test 4.15-openshift-e2e /test 4.16-openshift-e2e

slintes commented 2 months ago

/test 4.12-openshift-e2e

mshitrit commented 2 months ago

/lgtm

slintes commented 2 months ago

/retest

openshift-cherrypick-robot commented 2 months ago

@slintes: new pull request created: #346

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/345#issuecomment-2274035235): >/cherry-pick release-0.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.