[WIP] MHC created CR isn't deleted by the remediator

mshitrit commented 1 month ago

Why we need this PR

When a CR is created by MHC it's not deleted by the remediator (SNR) in case the remediator supports multiple templates. The reason is that when MHC creates the CR it creates a generated name for the CR which does not match the machine name. When the same apply for node base remediation the additional (node name and template name) info is stored in annotations on the CR, but for machine based remediation the remediator doesn't access those annotations.

Changes made

When creating an MHC remediation CR using the machine name and not generated name.
Multiple support annotation "NodeName" will now hold the correct node name (instead of the machine name) or empty value in case there is an issue getting the node name.

Which issue(s) this PR fixes

ECOPROJECT-2077

Test plan

Added a regression test

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

mshitrit commented 1 month ago

/test ?

openshift-ci[bot] commented 1 month ago

@mshitrit: The following commands are available to trigger required jobs:

/test 4.12-ci-bundle-my-bundle
/test 4.12-images
/test 4.12-openshift-e2e
/test 4.12-test
/test 4.13-ci-bundle-my-bundle
/test 4.13-images
/test 4.13-openshift-e2e
/test 4.13-test
/test 4.14-ci-bundle-my-bundle
/test 4.14-images
/test 4.14-openshift-e2e
/test 4.14-test
/test 4.15-ci-bundle-my-bundle
/test 4.15-images
/test 4.15-openshift-e2e
/test 4.15-test
/test 4.16-ci-bundle-my-bundle
/test 4.16-images
/test 4.16-openshift-e2e
/test 4.16-test
/test 4.17-ci-bundle-my-bundle
/test 4.17-images
/test 4.17-openshift-e2e
/test 4.17-test

Use /test all to run all jobs.

In response to [this](https://github.com/medik8s/node-healthcheck-operator/pull/347#issuecomment-2337491273): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

mshitrit commented 1 month ago

/test 4.16-openshift-e2e

mshitrit commented 1 month ago

/test 4.16-openshift-e2e

mshitrit commented 1 month ago

/test 4.16-openshift-e2e

mshitrit commented 1 month ago

/test 4.16-openshift-e2e

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-healthcheck-operator/blob/main/OWNERS)~~ [mshitrit,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

mshitrit commented 1 month ago

/test 4.16-openshift-e2e

openshift-ci[bot] commented 1 month ago

@mshitrit: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.16-openshift-e2e	e51cac5bb231cd2c909d7cc8a0da5b19aa317283	link	true	`/test 4.16-openshift-e2e`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

medik8s / node-healthcheck-operator