search

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
25 stars 13 forks source link

Disable HTTP/s on webhook server #100

Closed slintes closed 9 months ago

slintes commented 9 months ago

Mitigates HTTP/2 CVE

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 9 months ago

/test 4.13-images

slintes commented 9 months ago

/retest

slintes commented 9 months ago

flaky test /override ci/prow/4.14-openshift-e2e

/cherry-pick release-0.14 /cherry-pick release-0.16

openshift-cherrypick-robot commented 9 months ago

@slintes: once the present PR merges, I will cherry-pick it on top of release-0.14 in a new PR and assign it to you.

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/100#issuecomment-1772597668): >flaky test >/override ci/prow/4.14-openshift-e2e > >/cherry-pick release-0.14 >/cherry-pick release-0.16 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 9 months ago

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.14-openshift-e2e

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/100#issuecomment-1772597668): >flaky test >/override ci/prow/4.14-openshift-e2e > >/cherry-pick release-0.14 >/cherry-pick release-0.16 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 9 months ago

@slintes: #100 failed to apply on top of branch "release-0.14":

Applying: Disable HTTP/s on webhook server
Using index info to reconstruct a base tree...
M   api/v1beta1/nodemaintenance_webhook.go
M   main.go
Falling back to patching base and 3-way merge...
Auto-merging main.go
CONFLICT (content): Merge conflict in main.go
Auto-merging api/v1beta1/nodemaintenance_webhook.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Disable HTTP/s on webhook server
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/100#issuecomment-1772597668): >flaky test >/override ci/prow/4.14-openshift-e2e > >/cherry-pick release-0.14 >/cherry-pick release-0.16 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 9 months ago

@slintes: new pull request created: #101

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/100#issuecomment-1772597668): >flaky test >/override ci/prow/4.14-openshift-e2e > >/cherry-pick release-0.14 >/cherry-pick release-0.16 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.