NMO handling the new Exclude From remediation label on the node

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources

https://www.medik8s.io/maintenance-node/

Apache License 2.0

25 stars 13 forks source link

NMO handling the new Exclude From remediation label on the node #105

Closed mshitrit closed 7 months ago

mshitrit commented 7 months ago

ECOPROJECT-1747 , ECOPROJECT-1779, ECOPROJECT-1785

Supporting snr feature, making sure that once a node is put into maintenance by NMO it will apply the label which will cause SNR to stop running on that node. This functionality is required for use cases where we would like to disable SNR (for example Node maintenance).

openshift-ci[bot] commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [mshitrit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mshitrit commented 7 months ago

/test ?

openshift-ci[bot] commented 7 months ago

@mshitrit: The following commands are available to trigger required jobs:

/test 4.12-ci-index
/test 4.12-images
/test 4.12-openshift-e2e
/test 4.13-ci-index
/test 4.13-images
/test 4.13-openshift-e2e
/test 4.14-ci-index
/test 4.14-images
/test 4.14-openshift-e2e
/test 4.15-ci-index
/test 4.15-images
/test 4.15-openshift-e2e

Use /test all to run all jobs.

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/105#issuecomment-1838129772): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

mshitrit commented 7 months ago

/test 4.13-openshift-e2e

mshitrit commented 7 months ago

/test 4.13-openshift-e2e

slintes commented 7 months ago

/lgtm

mshitrit commented 7 months ago

/retest