search

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
25 stars 13 forks source link

Set Suggested Namespace #107

Closed razo7 closed 7 months ago

razo7 commented 7 months ago

The suggested namespace is used to resolve the confusion of installing the operator from the console vs CLI. We use two new OCP annotations for this matter and to make sure that "openshift.io/node-selector":"" annotation is set on the installed namespace.

Similar to https://github.com/medik8s/self-node-remediation/pull/165, https://github.com/medik8s/self-node-remediation/pull/168 and related to ECOPROJECT-1778

openshift-ci[bot] commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 7 months ago

/test 4.14-openshift-e2e /test 4.15-openshift-e2e

mshitrit commented 7 months ago

/lgtm

razo7 commented 7 months ago

/retest

razo7 commented 7 months ago

/retest

razo7 commented 7 months ago

/retest

mshitrit commented 7 months ago

/retest

razo7 commented 7 months ago

/retest