Set Replace Annotation - Githubissues

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources

https://www.medik8s.io/maintenance-node/

Apache License 2.0

28 stars 14 forks source link

Set Replace Annotation #108

Closed razo7 closed 9 months ago

razo7 commented 9 months ago

Even though we use 'skipRange' for defining from which versions we can update to the version of the CSV, we also need to add the 'replace' field. It should point to the last released version and ensure that the old version isn't deleted from the index.

https://docs.engineering.redhat.com/display/CFC/Best_Practices#Best_Practices-SkipRange

openshift-ci[bot] commented 9 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mshitrit commented 9 months ago

/test ?

openshift-ci[bot] commented 9 months ago

@mshitrit: The following commands are available to trigger required jobs:

/test 4.12-ci-index
/test 4.12-images
/test 4.12-openshift-e2e
/test 4.13-ci-index
/test 4.13-images
/test 4.13-openshift-e2e
/test 4.14-ci-index
/test 4.14-images
/test 4.14-openshift-e2e
/test 4.15-ci-index
/test 4.15-images
/test 4.15-openshift-e2e

Use /test all to run all jobs.

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/108#issuecomment-1870287968): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

mshitrit commented 9 months ago

/test 4.13-openshift-e2e

razo7 commented 9 months ago

/test 4.15-openshift-e2e

mshitrit commented 9 months ago

/lgtm

razo7 commented 9 months ago

/retest

razo7 commented 9 months ago

/retest

razo7 commented 9 months ago

/retest