medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
25 stars 13 forks source link

Update Tools & APIs #111

Closed razo7 closed 6 months ago

razo7 commented 6 months ago
openshift-ci[bot] commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 6 months ago

/test 4.15-openshift-e2e

razo7 commented 6 months ago

/test 4.15-openshift-e2e

razo7 commented 6 months ago

/test 4.15-openshift-e2e

clobrano commented 6 months ago

Can you add a comment in the last commit about why the webhook update was needed?

razo7 commented 6 months ago

Can you add a comment in the last commit about why the webhook update was needed?

There were some breaking changes in sigs.k8s.io/controller-runtime v0.14.5 -> v0.16.3 (see v0.15.0 and v0.16.0).

razo7 commented 6 months ago

/test 4.15-openshift-e2e

clobrano commented 6 months ago

/lgtm

razo7 commented 6 months ago

/retest

razo7 commented 6 months ago

/retest

razo7 commented 6 months ago

/lgtm

openshift-ci[bot] commented 6 months ago

@razo7: you cannot LGTM your own PR.

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/111#issuecomment-1893311253): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
razo7 commented 6 months ago

oops 😃 I meant to retest /retest