Reconcile Refactor

[razo7]

• Informative maintenance log message.
• Use commonLabels, private variables instead of public. Refactor variable name and import API name.
• Refactor Finalizer handling with controllerutil
• Refactor reconcile.result, replace deprecated k8s.io/utils/pointer package
• Use the Reconcile context (ctx) and also pass it between functions for get/update calls.
• Create drain Helper per each reconcile

[openshift-ci[bot]]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[mshitrit]

/test 4.15-openshift-e2e

[mshitrit]

/lgtm Just nits, feel free to ignore

[mshitrit]

/lgtm

[razo7]

/test 4.15-openshift-e2e

[razo7]

/test 4.15-openshift-e2e

[razo7]

/test 4.15-openshift-e2e

[razo7]

/test 4.15-openshift-e2e

[razo7]

/test 4.15-openshift-e2e

[razo7]

/test 4.15-openshift-e2e

[razo7]

/test 4.15-openshift-e2e

[razo7]

Beside that, can you please make the context the 1st argument for all method

I initially did that but then I thought that the variable order, in the function declaration, should be in the order of appearance in the function (the second variable will be used only after the first one and not after the third one).

like it is in client-go as well? I think that would make the code at least a bit better readable.

I wasn't aware of that, but I can do that if it makes more sense

[razo7]

/retest

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[razo7]

/unhold

[razo7]

/retest