medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
27 stars 14 forks source link

Consistent Makefile between Medik8s Operators - Updating Targets #12

Closed razo7 closed 2 years ago

razo7 commented 2 years ago

For better collaboration I am aligning our Makefiles, and this is the first PR. It would be easier (or not) to see changes, commit after commit.

  1. Add PHONY to each target and update it's description (use make help)
  2. Use kubectl or oc and 'test-no-verify` target (for passing CI test when there are uncommitted changes).
razo7 commented 2 years ago

/hold Waiting with the other PRs, till we finish the next release. It is not urgent.

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 2 years ago

/hold cancel A new try to make consistent Makefile, the PR's description has been changed

razo7 commented 2 years ago

/retest

razo7 commented 2 years ago

Since the changes require reordering the file and for better reviewing the changes I am splitting this PR. Next PRs will include go install tool - #36, Operator-sdk upgrade changes - #34 , Updating Go, K8s - #35 , Bundle Creation Addition - #68, and Reordering Makefile by categories.

mshitrit commented 2 years ago

/lgtm