search

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
25 stars 13 forks source link

Add Eviction Timeout Field for Maintenance Time #122

Closed razo7 closed 4 months ago

razo7 commented 5 months ago

What this PR does / why we need it:

Adds a new Spec field for the pod's eviction timeout. Configurable pod's eviction drain/deletion timeout for the user, while previously it was set to 30s (the default value).

Changes made

Which issue(s) this PR fixes:

ECOPROJECT-1668

Test plan

Add e2e test for different evicitonTimeout values - high (50s) vs. low (10s)

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 5 months ago

/test 4.15-openshift-e2e

razo7 commented 4 months ago

/test 4.15-openshift-e2e There are more (possible) changes for the e2e testing, but it can be done afterward and mostly when there are maintenance events.

razo7 commented 4 months ago

/test 4.15-openshift-e2e

openshift-ci[bot] commented 4 months ago

@razo7: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.15-openshift-e2e 410b51c555dc5b1419b43d7d82db6074c51856f3 link true /test 4.15-openshift-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
razo7 commented 4 months ago

Closing this PR as its goal is minor, it introduces a possible longer reconciliation (while we strive for a short reconcile), an API change, and the gain doesn't worth the effort