search

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
28 stars 14 forks source link

Separate nm status initalization from update #123

Closed razo7 closed 7 months ago

razo7 commented 7 months ago

What this PR does / why we need it:

Take out the nm CR update from the initMaintenanceStatus function so the function can easily be tested (and succeeded) in UTs. to only nm status initialization and update is done afterward. It is mostly needed for UTs of the initMaintenanceStatus function

Changes made

Separation of initMaintenanceStatus logic to only nm status initialization and update is done only afterwards. It is mostly needed for UTs of the initMaintenanceStatus function

Which issue(s) this PR fixes:

Follow up for comment

openshift-ci[bot] commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

razo7 commented 7 months ago

/test 4.15-openshift-e2e

razo7 commented 7 months ago

/test 4.15-openshift-e2e

razo7 commented 7 months ago

/test 4.15-openshift-e2e

razo7 commented 7 months ago

/retest

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [clobrano,razo7,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 7 months ago

/retest