medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
25 stars 13 forks source link

Skip previous version validation in CI #124

Closed razo7 closed 4 months ago

razo7 commented 4 months ago

Why we need this PR

Should fix an error when VERSION equals CI_VERSION, so it would skip the previous version validation in CI

Error in post-submit automation

make[1]: Entering directory '/home/go/src/github.com/medik8s/node-maintenance-operator' 924 Error: PREVIOUS_VERSION must be set for the selected VERSION VERSION equals CI_VERSION,

Changes made

Modify the verify-previous-version target so it fails when VERSION doesn't equal CI_VERSION. Similar to SNR PR

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

razo7 commented 4 months ago

The PR is not affecting the code, but rather the GitHub CI so no need to set the PR as draft

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [clobrano,razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 4 months ago

/cherry-pick release-0.17

openshift-cherrypick-robot commented 4 months ago

@razo7: new pull request created: #125

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/124#issuecomment-1994823733): >/cherry-pick release-0.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.