Verify previous version only when it is needed

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources

https://www.medik8s.io/maintenance-node/

Apache License 2.0

25 stars 13 forks source link

Verify previous version only when it is needed #127

Closed razo7 closed 4 months ago

razo7 commented 4 months ago

Why we need this PR

Fix a problem that causes pushing tags to fail and pushing git tags to Quay.

Changes made

Now the target makes sure to fail on a bad PREVIOUS_VERSION value

PREVIOUS_VERSION was set but it equals to VERSION
PREVIOUS_VERSION wasn't set but VERSION was set (and we skip it in CI by setting the SKIP_VERIFY_PREVIOUS_VERSION in post-submit)

Which issue(s) this PR fixes

An issue with the verify-previous-version target that wasn't fixed properly in #124

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

clobrano commented 4 months ago

If you don't provide PREVIOUS_VERSION to CI when github.ref_type == 'tag' is true, would the manifests attached to the release (also done when the same condition is true) won't have the replaces field?

razo7 commented 4 months ago

There was some confusion about whether the validation was needed. We do want it and on pushing tags to GitHub we would like to use a manual workflow that will have a proper PREVIOUS_VERSION value. I am closing this one in favor of a new one that will fix the issue.