medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
25 stars 13 forks source link

Fix Github CI Test #128

Closed razo7 closed 4 months ago

razo7 commented 4 months ago

Why we need this PR

CI test of unit-test failed due to redundant space/tab from #113. In check target we use test-no-verify target that doesn't check for modified files, while it should use test target that won't accept modified files (using verify-unchanged target)

Changes made

Which issue(s) this PR fixes

Fixes unit-test from make test. Found in https://github.com/openshift/release/pull/49534

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 4 months ago

/retest

razo7 commented 4 months ago

/retest