Closed razo7 closed 2 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: razo7
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I have updated to Go 1.17, K8s 1.23 and related packages (to the relevant Go 1.17 version) since the latest Operator-SKD is still using K8s 1.23 and Go 1.17.
commit number 4 (Switch go-get to go-install) can be discarded after merging #12.
I am closing this PR since appending the two commits form #34 to #35 helped passing the Github test.
Originally the idea was to create small disconnected PRs, but I didn't apply to this PR (#34) and #35.
This PR failed with Github test error which looks like it is related to Go version (in Operator sdk version v1.21.0 they use Go 1.17 and in this PR I still have Go 1.16) while in #35 this test fails again with go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17
error.
Therefore, I have suspected that they both fail because for using the newest version for the Makefile tools (in #34 ) I need Go 1.18 and for Go 1.18 (#35) I need the newest version of the Makefile tools....
This was supposed to be the third PR.
make bundle
.