medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
27 stars 13 forks source link

Consistent Makefile between Medik8s Operators - Add Operator-SDK changes & Update tools #34

Closed razo7 closed 2 years ago

razo7 commented 2 years ago

This was supposed to be the third PR.

  1. Upgrade Operator SDK changes from V1.12 to v1.21 (v1.14, v1.16, v1.17, v1.18, and v1.21).
  2. Updating the Makefile tools version (to the latest version, except Ginkgo which is a major update) & Operator-sdk v1.21.0, and then run make bundle.
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 2 years ago

I have updated to Go 1.17, K8s 1.23 and related packages (to the relevant Go 1.17 version) since the latest Operator-SKD is still using K8s 1.23 and Go 1.17.

razo7 commented 2 years ago

commit number 4 (Switch go-get to go-install) can be discarded after merging #12.

razo7 commented 2 years ago

I am closing this PR since appending the two commits form #34 to #35 helped passing the Github test.

Originally the idea was to create small disconnected PRs, but I didn't apply to this PR (#34) and #35. This PR failed with Github test error which looks like it is related to Go version (in Operator sdk version v1.21.0 they use Go 1.17 and in this PR I still have Go 1.16) while in #35 this test fails again with go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17 error. Therefore, I have suspected that they both fail because for using the newest version for the Makefile tools (in #34 ) I need Go 1.18 and for Go 1.18 (#35) I need the newest version of the Makefile tools....