search

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
27 stars 13 forks source link

Consistent Makefile between Medik8s Operators - Update Versions #35

Closed razo7 closed 2 years ago

razo7 commented 2 years ago

For better collaboration I am aligning our Makefiles, and this is the third PR. This PR is about updating versions:

  1. Upgrade Operator SDK changes from V1.12 to v1.21 (v1.14, v1.16, v1.17, v1.18, and v1.21).
  2. Updating the Makefile tools version (to the latest version, except Ginkgo which is a major update) & Operator-sdk v1.21.0, and then run make bundle.
  3. Update from Go 1,16 and K8s 1.21 to Go 1,18 and K8s 1.23
  4. Automatic change after running make go-verify.
  5. Use check in docker-build target (due to go mod tidy error).
razo7 commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 2 years ago

Last commit was added due to go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17 error which has been resolved by running test-no-verify with DOCKER_GO.