search

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
27 stars 13 forks source link

Consistent Makefile between Medik8s Operators - Installation tools #36

Closed razo7 closed 2 years ago

razo7 commented 2 years ago

For better collaboration I am aligning our Makefiles, and this is the second PR.

Adding two functions for installing tools -go-install-tool and operator-framework-tool because of the deprecation of 'go get' for installing executables. They both remove the old directory, and then install (with go install rather than go-get)/download the tool into a new directory under the bin directory. In addition to that we are passing the Ginkgo version for e2e tests.

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 2 years ago

/retest

slintes commented 2 years ago

/lgtm