medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
27 stars 13 forks source link

Add drain duration information #41

Closed razo7 closed 2 years ago

razo7 commented 2 years ago

Provide feedback for long running drain operations by adding two fields regarding their progress in the nodemaintenance CR status.

razo7 commented 2 years ago

I used crd:allowDangerousTypes=true for using float64 in the CRD after getting the following notification/error when running make manifests:

"found float, the usage of which is highly discouraged, as support for them varies across languages. Please consider serializing your float as string instead. If you are really sure you want to use them, re-run with crd:allowDangerousTypes=true"

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 2 years ago
razo7 commented 2 years ago

/retest

razo7 commented 2 years ago

/retest

razo7 commented 2 years ago

/retest

razo7 commented 2 years ago

AWS CI is flaky today (something is wrong with the last image release for OCP 4.11 in AWS).

unable to import latest release image: imagestream.image.openshift.io "release" not found

razo7 commented 2 years ago

/retest

slintes commented 2 years ago

/lgtm