Extend Bundle Validation with Three more Validators

razo7 commented 1 year ago

Running the operator-sdk validation without any flags validates the bundle format and conforms it's contents to what is allowed in a registry+v1 bundle (see ValidateBundleFormat and ValidateBundleContent functions).

This PR extends our bundle validation to three more validators (from operatorframework suite):

operatorhub validates the bundle manifests against the required criteria to publish // the projects on OperatorHub.io.
alpha-deprecated-apis validates the bundle for Kubernetes deprecated APIs versions based on the bundle.CSV.Spec.MinKubeVersion value (and --optional-values=k8s-version=K8S_VERSION if provided) . The validation will error if it knows you are using a deprecated API and warn if it thinks there could be a deprecated API being used. Currently, operator-sdk v1.26.0, it supports only three deprecated Kubernetes API versions.
good-practices validates the bundle against criteria and suggestions defined as good practices for bundles under the operator-framework solutions.

To see more options for using the bundle validation - Please run operator-sdk bundle validate --list-optional

razo7 commented 1 year ago

/retest

razo7 commented 1 year ago

After understanding that we don't have preference on Kubernetes version for validating deprecated APIs, then we use bundle.CSV.Spec.MinKubeVersion value.

PR's title and description have been updated.

razo7 commented 1 year ago

/retest

razo7 commented 1 year ago

/retest

razo7 commented 1 year ago

/retest

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [clobrano,razo7,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

razo7 commented 1 year ago

/retest

razo7 commented 1 year ago

/retest

razo7 commented 1 year ago

/retest

medik8s / node-maintenance-operator

Extend Bundle Validation with Three more Validators #64