medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
27 stars 13 forks source link

Consistent Makefile between Medik8s Operators - Bundle Creation Addition #68

Closed razo7 closed 1 year ago

razo7 commented 1 year ago

For better collaboration I am aligning our Makefiles, and this is the fourth PR.

Small changes to bundle creation (similarly to NHC and SNR PRs)

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mshitrit commented 1 year ago

/lgtm

razo7 commented 1 year ago

Similar problem as it was in #50 for OCP 4.13, thus it is irrelevant to the PR changes. /override ci/prow/4.13-openshift-e2e

openshift-ci[bot] commented 1 year ago

@razo7: Overrode contexts on behalf of razo7: ci/prow/4.13-openshift-e2e

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/68#issuecomment-1367183633): >Similar problem as it was in #50 for OCP 4.13, thus it irrelevant to the PR changes. >/override ci/prow/4.13-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
razo7 commented 1 year ago

/retest