Update ginkgo v2 - Githubissues

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources

https://www.medik8s.io/maintenance-node/

Apache License 2.0

27 stars 13 forks source link

Update ginkgo v2 #69

Closed razo7 closed 1 year ago

razo7 commented 1 year ago

NMO has been using the last Ginkgo v1 version, v1.16.5, from Oct 2021. This PR bumps to a new major release of Ginkgo, and to the latest Ginkgo version, v2.8.0.

Replace ginkgo to ginkgo/v2
Run make go-verify
Apply Ginkgo v2 changes (RunSpecs, removing timeout BeforeSuite, and new flag names)

razo7 commented 1 year ago

/retest

razo7 commented 1 year ago

/retest

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

razo7 commented 1 year ago

/unhold