medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
27 stars 13 forks source link

Bump Golang and Makefile Tools Version #75

Closed razo7 closed 1 year ago

razo7 commented 1 year ago
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 1 year ago

/hold

unsure if we should update to Go 1.20 already...

razo7 commented 1 year ago

The PR was on hold mainly because there were no Golang v1.20 builders in OCP CI, thus OCP CI would fail on mismatch of Golang version if we would have merge this PR and don't use a matched Golang v1.20 builder in OCP CI.

ATM it can be merged since there is a new Golang v1.20 builder for OCP CI (for OCP 4.14 and not 4.13 -> rhel-8-golang-1.20-openshift-4.14), e.g. in _build_root.image_streamtag.tag .

razo7 commented 1 year ago

/retest

slintes commented 1 year ago

/lgtm

razo7 commented 1 year ago

/unhold