search

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
25 stars 13 forks source link

Fix Ginkgo mismatch version #84

Closed razo7 closed 1 year ago

razo7 commented 1 year ago

Ginkgo version in Makefile is v2.9.1, while on go.mod it is only 2.8.0

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 1 year ago

/retest

clobrano commented 1 year ago

/lgtm

Giving others a chance to review as well, feel free to unhold /hold

razo7 commented 1 year ago

/unhold