medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
28 stars 14 forks source link

Use lease logic from common repo #86

Closed mshitrit closed 1 year ago

mshitrit commented 1 year ago
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [mshitrit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 1 year ago

/lgtm

Giving a chance to get more feedbacks, feel free to unhold /hold

mshitrit commented 1 year ago

/retest

mshitrit commented 1 year ago

/retest

clobrano commented 1 year ago

/lgtm

Giving a chance to get more feedbacks, feel free to unhold /hold

mshitrit commented 1 year ago

Thanks ! in any case not planning to merge before:

mshitrit commented 1 year ago

/retest

mshitrit commented 1 year ago

/retest

mshitrit commented 1 year ago

/unhold

clobrano commented 1 year ago

/lgtm