search

medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
25 stars 13 forks source link

[WIP] Extend E2E Test Timeout for Flaky Tests #88

Closed razo7 closed 7 months ago

razo7 commented 1 year ago

NMO E2E test have been quite flaky lately, thus I was looking on the last failed PRs of NMO for OCP 4.11, 4.12, 4.13, and 4.14 (from March 16th), in order to see why the E2E tests were flaky.

There are four questionable tests that by extending there test time we might let them finish successfully:

  1. for the 1st master/control-plane node - should succeed
  2. for the 2nd master/control-plane node - should fail
  3. should result in resetted node status
  4. should have invalidated the lease
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [razo7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
razo7 commented 1 year ago

/retest

openshift-merge-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 10 months ago

@razo7: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-openshift-e2e 0cab53c66c8ac3a0c9c94c1e5ee65ebb035057cd link true /test 4.11-openshift-e2e
ci/prow/4.14-openshift-e2e 0cab53c66c8ac3a0c9c94c1e5ee65ebb035057cd link true /test 4.14-openshift-e2e
ci/prow/4.15-ci-index 0cab53c66c8ac3a0c9c94c1e5ee65ebb035057cd link true /test 4.15-ci-index
ci/prow/4.15-openshift-e2e 0cab53c66c8ac3a0c9c94c1e5ee65ebb035057cd link true /test 4.15-openshift-e2e
ci/prow/4.15-images 0cab53c66c8ac3a0c9c94c1e5ee65ebb035057cd link true /test 4.15-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
razo7 commented 7 months ago

e2e tests are not flaky as in the past. we might revisit this PR in the future.