medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
25 stars 13 forks source link

fixing e2e test #90

Closed mshitrit closed 1 year ago

mshitrit commented 1 year ago

Fixing E2E test as a Follow up of @slintes comments on this PR

mshitrit commented 1 year ago

/retest

mshitrit commented 1 year ago

/retest

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [mshitrit,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
slintes commented 1 year ago

/retest

mshitrit commented 1 year ago

/override 4.14-openshift-e2e

openshift-ci[bot] commented 1 year ago

@mshitrit: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/90#issuecomment-1565935939): >/override 4.14-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mshitrit commented 1 year ago

/override ci/prow/4.14-openshift-e2e

openshift-ci[bot] commented 1 year ago

@mshitrit: Overrode contexts on behalf of mshitrit: ci/prow/4.14-openshift-e2e

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/90#issuecomment-1565936005): >/override ci/prow/4.14-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.