medik8s / node-maintenance-operator

Kubernetes Operator to manage node maintenance through NodeMaintenance custom resources
https://www.medik8s.io/maintenance-node/
Apache License 2.0
28 stars 14 forks source link

Adjust to API changes made to lease logic in common repo #91

Closed mshitrit closed 1 year ago

mshitrit commented 1 year ago

Making changes in order to align with PR: https://github.com/medik8s/common/pull/2

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/node-maintenance-operator/blob/main/OWNERS)~~ [mshitrit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
clobrano commented 1 year ago

/lgtm

Giving a chance to get more feedbacks, feel free to unhold /hold

openshift-ci[bot] commented 1 year ago

@mshitrit: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/medik8s/node-maintenance-operator/pull/91#issuecomment-1586079211): >/test ci/prow/4.13-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mshitrit commented 1 year ago

/test 4.13-openshift-e2e

mshitrit commented 1 year ago

/retest

mshitrit commented 1 year ago

/retest

razo7 commented 1 year ago

/lgtm

mshitrit commented 1 year ago

/unhold