Closed agrrh closed 6 months ago
Hi @agrrh. Thanks for your PR.
I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/test 4.15-openshift-e2e
Seems like some random failure:
Self Node Remediation E2E Control Plane Remediation [AfterEach] With API connectivity creating a SNR Resource Deletion Strategy should delete pods and volume attachments
[AfterEach] /go/src/github.com/medik8s/self-node-remediation/e2e/self_node_remediation_test.go:317
[It] /go/src/github.com/medik8s/self-node-remediation/e2e/self_node_remediation_test.go:358
[FAILED] Timed out after 1200.009s.
pod did not get ready in time
Expected
<v1.ConditionStatus>: False
to equal
<v1.ConditionStatus>: True
In [AfterEach] at: /go/src/github.com/medik8s/self-node-remediation/e2e/self_node_remediation_test.go:619 @ 04/24/24 11:35:50.151
Not sure if I'm allowed to trigger CI here. Would give it a try.
/test 4.15-openshift-e2e
@agrrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
Yep, I'm not allowed to restart it.
@slintes kindly asking you to take a look, please.
/retest
@agrrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
/test 4.15-openshift-e2e
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: agrrh, slintes
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/unhold
Why we need this PR
It enables kube-rbac-proxy container so we could reach metrics.
Changes made
manager_auth_proxy_patch.yaml
Which issue(s) this PR fixes
Fixes #196, as I hope :)
ECOPROJECT-1949
Test plan