medik8s / self-node-remediation

Automatic repair for unhealthy Kubernetes nodes
https://www.medik8s.io/
Apache License 2.0
45 stars 17 forks source link

Enable kube-rbac-proxy to be able to reach metrics #199

Closed agrrh closed 6 months ago

agrrh commented 6 months ago

Why we need this PR

It enables kube-rbac-proxy container so we could reach metrics.

Changes made

Which issue(s) this PR fixes

Fixes #196, as I hope :)

ECOPROJECT-1949

Test plan

openshift-ci[bot] commented 6 months ago

Hi @agrrh. Thanks for your PR.

I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
slintes commented 6 months ago

/test 4.15-openshift-e2e

agrrh commented 6 months ago

Seems like some random failure:

Self Node Remediation E2E Control Plane Remediation [AfterEach] With API connectivity creating a SNR Resource Deletion Strategy should delete pods and volume attachments
  [AfterEach] /go/src/github.com/medik8s/self-node-remediation/e2e/self_node_remediation_test.go:317
  [It] /go/src/github.com/medik8s/self-node-remediation/e2e/self_node_remediation_test.go:358
  [FAILED] Timed out after 1200.009s.
  pod did not get ready in time
  Expected
      <v1.ConditionStatus>: False
  to equal
      <v1.ConditionStatus>: True
  In [AfterEach] at: /go/src/github.com/medik8s/self-node-remediation/e2e/self_node_remediation_test.go:619 @ 04/24/24 11:35:50.151

Not sure if I'm allowed to trigger CI here. Would give it a try.

agrrh commented 6 months ago

/test 4.15-openshift-e2e

openshift-ci[bot] commented 6 months ago

@agrrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/medik8s/self-node-remediation/pull/199#issuecomment-2074779925): >/test 4.15-openshift-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
agrrh commented 6 months ago

Yep, I'm not allowed to restart it.

@slintes kindly asking you to take a look, please.

agrrh commented 6 months ago

/retest

openshift-ci[bot] commented 6 months ago

@agrrh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/medik8s/self-node-remediation/pull/199#issuecomment-2074852250): >/retest Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
clobrano commented 6 months ago

/test 4.15-openshift-e2e

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agrrh, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/self-node-remediation/blob/main/OWNERS)~~ [slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mshitrit commented 6 months ago

/unhold