Support Multiple Same Kind Remediation

medik8s / self-node-remediation

Automatic repair for unhealthy Kubernetes nodes

https://www.medik8s.io/

Apache License 2.0

45 stars 17 forks source link

Support Multiple Same Kind Remediation #200

Closed clobrano closed 4 months ago

clobrano commented 5 months ago

Why we need this PR

This PR will enable the user to select several SNR Templates (of the same kind) when using NHC escalating remediation.

This feature is dependent on the changes in NHC as well (which is available starting from NHC 0.8.0).

Changes made

Automatically add the MultipleTemplatesSupportedAnnotation that enables this feature via "Defaulting" (Mutating) webhook.
Support that Node's name might come from NodeNameAnnotation instead than from remediation's name (when the feature is enabled).
Updated Common package to the version shipping the new annotations needed by this feature.
Test coverage for both configurations (supported and unsupported multiple same kind remediation).

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-1930

Test plan

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

clobrano commented 5 months ago

/test 4.15-openshift-e2e

clobrano commented 5 months ago

/test 4.15-openshift-e2e

clobrano commented 5 months ago

/test 4.15-openshift-e2e

mshitrit commented 5 months ago

/lgtm

clobrano commented 5 months ago

/retest

clobrano commented 5 months ago

/retest

clobrano commented 5 months ago

/retest

clobrano commented 4 months ago

/retest

clobrano commented 4 months ago

/test 4.15-openshift-e2e

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/medik8s/self-node-remediation/blob/main/OWNERS)~~ [clobrano,slintes] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

clobrano commented 4 months ago

/retest

clobrano commented 4 months ago

/test 4.13-openshift-e2e

clobrano commented 4 months ago

the problem on 4.16 does not depend on us /override "ci/prow/4.16-openshift-e2e"

openshift-ci[bot] commented 4 months ago

@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.16-openshift-e2e

In response to [this](https://github.com/medik8s/self-node-remediation/pull/200#issuecomment-2163010239): >the problem on 4.16 does not depend on us >/override "ci/prow/4.16-openshift-e2e" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.