Closed clobrano closed 4 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/test 4.15-openshift-e2e
/test 4.15-openshift-e2e
/test 4.15-openshift-e2e
/lgtm
/retest
/retest
/retest
/retest
/test 4.15-openshift-e2e
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: clobrano, slintes
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
/test 4.13-openshift-e2e
the problem on 4.16 does not depend on us /override "ci/prow/4.16-openshift-e2e"
@clobrano: Overrode contexts on behalf of clobrano: ci/prow/4.16-openshift-e2e
Why we need this PR
This PR will enable the user to select several SNR Templates (of the same kind) when using NHC escalating remediation.
This feature is dependent on the changes in NHC as well (which is available starting from NHC 0.8.0).
Changes made
MultipleTemplatesSupportedAnnotation
that enables this feature via "Defaulting" (Mutating) webhook.NodeNameAnnotation
instead than from remediation's name (when the feature is enabled).Which issue(s) this PR fixes
https://issues.redhat.com/browse/ECOPROJECT-1930
Test plan